Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(defaultConfigs): update from docker #613

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

dgiebert
Copy link
Contributor

@dgiebert dgiebert commented Jul 29, 2024

Description of the change

With the new proxy config added, I want to be able to remove all manual config in the helm chart and use env vars

Not sure this needs a new version, can be added to the next bigger release imo

Checklist

@provokateurin
Copy link
Member

We're just using the config from https://github.com/nextcloud/docker/blob/master/.config/reverse-proxy.config.php and try to stay in sync with it, so I'd prefer if it was submitted there first since the maintainers of the docker image will know if this makes sense. After that we can just add it here by updating the file from upstream. @jessebot what do you think about this process?

@provokateurin provokateurin mentioned this pull request Jul 29, 2024
4 tasks
@jessebot
Copy link
Collaborator

jessebot commented Jul 29, 2024

@provokateurin yeah, that makes sense to me. I think trying to keep in sync with the docker repo is ideal, because then we can also better collaborate across repos.

The only downside is that we're both, nextcloud/helm and nextcloud/docker, on different release cycles, so the docker image may take a month or two to merge something, which can sometimes mean we won't be able to merge that same thing for at least that amount of time.

@dgiebert
Copy link
Contributor Author

Then I will go ahead and create a PR against nextcloud/docker and reference it here.

@jessebot
Copy link
Collaborator

Thank you, @dgiebert ! 🙏

@jessebot jessebot added the blocked - upstream Blocked by an upstream repo or project. label Jul 29, 2024
Signed-off-by: Dominic Giebert <[email protected]>
Signed-off-by: WrenIX <[email protected]>
@wrenix
Copy link
Collaborator

wrenix commented Dec 19, 2024

nextcloud/docker#2272 is merged so i update all default-config

@wrenix wrenix changed the title Add FORWARDED_FOR_HEADERS to the reverse-proxy config fix(defaultConfigs): update from docker Dec 19, 2024
@wrenix wrenix merged commit ed0cb34 into nextcloud:main Dec 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked - upstream Blocked by an upstream repo or project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants