-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Postgresql, MariaDB, and Redis subcharts to the latest (⚠️ Major updates) #580
Conversation
Signed-off-by: jessebot <[email protected]>
Signed-off-by: jessebot <[email protected]>
Signed-off-by: jessebot <[email protected]>
Signed-off-by: jessebot <[email protected]>
Signed-off-by: jessebot <[email protected]>
… again Signed-off-by: jessebot <[email protected]>
perhaps it also makes sense to update the requires to be the new testing actions? (instead of |
Signed-off-by: JesseBot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't test, but changes LGTM
Ah yeah now the required workflows are messing this up again. Since everyone has to rebase anyway due to the chart version conflicts it's fine to just set the new jobs to be required. |
@jessebot feel free to merge, I already updated the required jobs. |
…or updates) (nextcloud#580) * update sub charts and add test for postgresql chart Signed-off-by: jessebot <[email protected]> * temporarily change the changes workflow to run on ubuntu-22.04 Signed-off-by: jessebot <[email protected]> * add helm and ct install steps for the installation jobs Signed-off-by: jessebot <[email protected]> * always run change detection step in integration testing steps Signed-off-by: jessebot <[email protected]> * always do a checkout before rest of integration test Signed-off-by: jessebot <[email protected]> * update the runs-on parameter for changes job to use ubuntu-latest-low again Signed-off-by: jessebot <[email protected]> --------- Signed-off-by: jessebot <[email protected]> Signed-off-by: JesseBot <[email protected]> Signed-off-by: switzerchees <[email protected]>
Description of the change
12.12.10
to15.5.0
12.2.9
to18.2.0
17.13.*
to19.5.0
As always, you need to check the official upgrade instructions from both bitnami and the upstream providers. Please see the following docs before attempting the nextcloud helm chart upgrade:
Benefits
We were pretty out of date on all our subcharts, and this also grants us an end to end test with postgresql, which we've been missing for a while.
Possible drawbacks
ct
command.Applicable issues
I feel like we had an issue for postgresql testing, but I can't find it right now 🤔
Additional information
You can see an example of the new testing workflow here where I ran it on my personal repo for this feature branch:
https://github.com/jessebot/nextcloud-helm/actions/runs/9347132143
In the future, renovateBot will take care of these updates for us, and then we just need to review them. I'm doing this manually now, because we're so very behind.
Checklist
Chart.yaml
according to semver.