Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Postgresql, MariaDB, and Redis subcharts to the latest (⚠️ Major updates) #580

Merged
merged 7 commits into from
Jun 9, 2024

Conversation

jessebot
Copy link
Collaborator

@jessebot jessebot commented Jun 3, 2024

⚠️ Major updates to sub charts

Description of the change

  • Updates postgresql chart from 12.12.10 to 15.5.0
  • Updates mariadb chart from 12.2.9 to 18.2.0
  • Updates redis chart from 17.13.* to 19.5.0
  • Adds a new job to test postgresql installs

As always, you need to check the official upgrade instructions from both bitnami and the upstream providers. Please see the following docs before attempting the nextcloud helm chart upgrade:

Benefits

We were pretty out of date on all our subcharts, and this also grants us an end to end test with postgresql, which we've been missing for a while.

Possible drawbacks

  • I don't have a test for mysql, only because I don't actually use mariadb, and don't have the time to create one right now, but if others want to submit that test, I'd be open to testing it locally :)
  • users will need to still follow the major upgrade docs listed above before they can upgrade, as is the case for all major upgrades of redis, mariadb, and postgresql
  • I have hardcoded a password for the testing of postgresql. We can easily update this to be a repo secret and then no password will be logged, but that requires someone with better access than myself to add that repo secret, and then tell me know what the name of it is, so I can update the ct command.

Applicable issues

I feel like we had an issue for postgresql testing, but I can't find it right now 🤔

Additional information

You can see an example of the new testing workflow here where I ran it on my personal repo for this feature branch:
https://github.com/jessebot/nextcloud-helm/actions/runs/9347132143
Screenshot of the summary section for the jessebot/nextcloud-helm feature branch workflow showing 4 jobs. The first job is the changes job, which then feeds into the linting job, which then triggers both the internal-database test and postgresql-database test. All 4 show as green, meaning success.

In the future, renovateBot will take care of these updates for us, and then we just need to review them. I'm doing this manually now, because we're so very behind.

Checklist

@jessebot jessebot added the 3. to review Waiting for reviews label Jun 3, 2024
@jessebot jessebot self-assigned this Jun 3, 2024
@jessebot
Copy link
Collaborator Author

jessebot commented Jun 3, 2024

perhaps it also makes sense to update the requires to be the new testing actions? (instead of lint-test, updating it to be test-internal-database)

@jessebot jessebot requested a review from provokateurin June 3, 2024 09:14
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test, but changes LGTM

@provokateurin
Copy link
Member

Ah yeah now the required workflows are messing this up again. Since everyone has to rebase anyway due to the chart version conflicts it's fine to just set the new jobs to be required.

@provokateurin
Copy link
Member

@jessebot feel free to merge, I already updated the required jobs.

@jessebot jessebot merged commit 3dfd22e into nextcloud:main Jun 9, 2024
5 checks passed
@jessebot jessebot deleted the update-sub-charts branch June 9, 2024 07:38
SwitzerChees pushed a commit to SwitzerChees/helm that referenced this pull request Jun 27, 2024
…or updates) (nextcloud#580)

* update sub charts and add test for postgresql chart

Signed-off-by: jessebot <[email protected]>

* temporarily change the changes workflow to run on ubuntu-22.04

Signed-off-by: jessebot <[email protected]>

* add helm and ct install steps for the installation jobs

Signed-off-by: jessebot <[email protected]>

* always run change detection step in integration testing steps

Signed-off-by: jessebot <[email protected]>

* always do a checkout before rest of integration test

Signed-off-by: jessebot <[email protected]>

* update the runs-on parameter for changes job to use ubuntu-latest-low again

Signed-off-by: jessebot <[email protected]>

---------

Signed-off-by: jessebot <[email protected]>
Signed-off-by: JesseBot <[email protected]>
Signed-off-by: switzerchees <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants