Allow to set environment variables to Nginx container #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessebot
reviewed
May 12, 2024
jessebot
reviewed
May 12, 2024
Signed-off-by: François Ménabé <[email protected]>
jessebot
approved these changes
May 31, 2024
|
approved, but waiting for tests to finish before merging |
SwitzerChees
pushed a commit
to SwitzerChees/helm
that referenced
this pull request
Jun 27, 2024
Signed-off-by: François Ménabé <[email protected]> Co-authored-by: JesseBot <[email protected]> Signed-off-by: switzerchees <[email protected]>
raynay-r
pushed a commit
to raynay-r/nextcloud-helm
that referenced
this pull request
Jun 28, 2024
Signed-off-by: François Ménabé <[email protected]> Co-authored-by: JesseBot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description of the change
Add the
nginx.extraEnvparameter allowing to pass environment variables to the Nginx container.Benefits
This is for example useful to set the timezone of the Nginx container through TZ environment variable (cf #494 and nginxinc/docker-nginx#149).
Possible drawbacks
None, the new parameter is optional.
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver.