chore: Prevent displaying constant diffs for nextcloud-token in ArgoCD #554
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When metrics are not enabled, the use of randAlphaNum was causing constant diffs for nextcloud-token in ArgoCD. To mitigate this issue, now nextcloud-token won't be configured when metrics are not enabled. Signed-off-by: kahirokunn <[email protected]>
kahirokunn
force-pushed
the
remove-unused-token
branch
from
ae8fe14 to
34a6394
Compare
jessebot
reviewed
Apr 10, 2024
Co-authored-by: JesseBot <[email protected]> Signed-off-by: kahirokunn <[email protected]>
Signed-off-by: JesseBot <[email protected]>
jessebot
approved these changes
Apr 30, 2024
jessebot
reviewed
Apr 30, 2024
Co-authored-by: JesseBot <[email protected]> Signed-off-by: kahirokunn <[email protected]>
jessebot
approved these changes
May 1, 2024
SwitzerChees
pushed a commit
to SwitzerChees/helm
that referenced
this pull request
Jun 27, 2024
nextcloud#554) * chore: Prevent displaying constant diffs for nextcloud-token in ArgoCD When metrics are not enabled, the use of randAlphaNum was causing constant diffs for nextcloud-token in ArgoCD. To mitigate this issue, now nextcloud-token won't be configured when metrics are not enabled. Signed-off-by: kahirokunn <[email protected]> * Update charts/nextcloud/templates/secrets.yaml Co-authored-by: JesseBot <[email protected]> Signed-off-by: kahirokunn <[email protected]> * Update charts/nextcloud/Chart.yaml Co-authored-by: JesseBot <[email protected]> Signed-off-by: kahirokunn <[email protected]> --------- Signed-off-by: kahirokunn <[email protected]> Signed-off-by: JesseBot <[email protected]> Co-authored-by: JesseBot <[email protected]> Signed-off-by: switzerchees <[email protected]>
raynay-r
pushed a commit
to raynay-r/nextcloud-helm
that referenced
this pull request
Jun 28, 2024
nextcloud#554) * chore: Prevent displaying constant diffs for nextcloud-token in ArgoCD When metrics are not enabled, the use of randAlphaNum was causing constant diffs for nextcloud-token in ArgoCD. To mitigate this issue, now nextcloud-token won't be configured when metrics are not enabled. Signed-off-by: kahirokunn <[email protected]> * Update charts/nextcloud/templates/secrets.yaml Co-authored-by: JesseBot <[email protected]> Signed-off-by: kahirokunn <[email protected]> * Update charts/nextcloud/Chart.yaml Co-authored-by: JesseBot <[email protected]> Signed-off-by: kahirokunn <[email protected]> --------- Signed-off-by: kahirokunn <[email protected]> Signed-off-by: JesseBot <[email protected]> Co-authored-by: JesseBot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description of the change
When metrics are not enabled, the use of randAlphaNum was causing constant diffs for nextcloud-token in ArgoCD. To mitigate this issue, now nextcloud-token won't be configured when metrics are not enabled.
Benefits
This change prevents unnecessary diffs in ArgoCD when metrics are not enabled, leading to a cleaner deployment process.
Possible drawbacks
None
Applicable issues
Additional information
None
Checklist
Chart.yamlaccording to semver.