Add nodeSelector, tolerations and affinity to metrics deployment #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SwitzerChees
force-pushed
the
add-metrics-affinity-toleration-nodeselector
branch
from
3cb13cf to
cf8a36f
Compare
|
Just added the options nodeSelector, tolerations and affinity to the metrics template. For our use case it is important to also be able to control the placement of this pod based on these rules. And probably other people will also be happy about that in the future. |
|
You need to bump the chart version btw. |
Done just a patch version. |
wrenix
approved these changes
Feb 11, 2024
jessebot
reviewed
Jun 17, 2024
jessebot
reviewed
Jun 17, 2024
jessebot
reviewed
Jun 17, 2024
SwitzerChees
force-pushed
the
add-metrics-affinity-toleration-nodeselector
branch
from
9efec16 to
735bd6d
Compare
|
Something looks off with all these commits, please rebase onto master to drop all of them. |
… deployment Signed-off-by: Patrick Michel <[email protected]> Signed-off-by: switzerchees <[email protected]> Signed-off-by: WrenIX <[email protected]>
wrenix
force-pushed
the
add-metrics-affinity-toleration-nodeselector
branch
from
00b3824 to
230e4e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Patrick Michel [email protected]