fix #489 resources indent in README #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in alignment with charts/nextcloud/templates/deployment.yaml#412 Signed-off-by: Marcel Wunderlich <[email protected]> Signed-off-by: Deaddy <[email protected]>
provokateurin
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description of the change
We remove an indent in the README.md so it matches the values file and the reference in the corresponding helm template file.
Benefits
The README.md matches the code.
Possible drawbacks
In general one could argue that having
resources:outside of thenextcloud:-Block in the values is not consistent with other components of the deployment, but for the sake of compatibility fixing the README seems to be appropriate.Applicable issues
Additional information
Chart.yamlaccording to semver.