[10기 김형남] TodoList with CRUD #215
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyeonHak
reviewed
Jul 12, 2021
rlatmdgns
reviewed
Jul 12, 2021
src/components/TodoList.js
Outdated
| this.store.setState(newState); | ||
| } | ||
| if (isDestroy) { | ||
| const newState = buildNewState("DELETE", this.store, e); | ||
| this.store.setState(newState); | ||
| } | ||
| }); | ||
| this.$app.addEventListener("dblclick", (e) => { |
There was a problem hiding this comment.
이벤트 콜백 함수를 따로 만들어서 관리하는 방법도 좋지 않을 까라는 생각을 해보았습니다.ㅎㅎ
rlatmdgns
reviewed
Jul 12, 2021
|
|
||
| export default class Store { |
There was a problem hiding this comment.
형남님 코드를 보면서 많이 배울 수 있었습니다 .!! 감사합니다 👍
hyoungnam
commented
Jul 26, 2021
| @@ -0,0 +1,3 @@ | |||
| export const $ = (node) => document.querySelector(node); | |||
| export const $all = (node) => document.querySelectorAll(node) | |||
| export const isInClassList = (tagName, eventTarget) => eventTarget.classList.contains(tagName) | |||
There was a problem hiding this comment.
Suggested change
| export const isInClassList = (tagName, eventTarget) => eventTarget.classList.contains(tagName) | |
| export const isClassListContains = (tagName, eventTarget) => eventTarget.classList.contains(tagName) |
좀 더 명확하게 적기
|
|
||
| export default class Store { | ||
| constructor() { | ||
| this.state = get(USER, { todos: [], view: "all" }); |
There was a problem hiding this comment.
store에 state를 저장하는 것은 결합이 강하고 역할이 많으니 좀 더 분리
| return this.state; | ||
| } | ||
| //SET | ||
| setState(newState) { |
| render() { | ||
| const { view, todos } = this.store.getState(); | ||
| //prettier-ignore | ||
| const curViewTodos = view === "all" ? todos |
There was a problem hiding this comment.
Suggested change
| const curViewTodos = view === "all" ? todos | |
| const currentViewTodos = view === "all" ? todos |
reduce 메소드를 사용할때만 cur 사용하기
Comment on lines
+1
to
+88
| //prettier-ignore | ||
| import { TOGGLE, DESTROY, DELETE, EDITING, EDIT } from "./constant.js"; | ||
| import { filterTodos } from "../../utils/helpers.js"; | ||
| import { $, isInClassList } from "../../utils/selectors.js"; | ||
|
|
||
| //MOUNT HELPER | ||
| export function toggleTodoItem(e, store) { | ||
| const isToggle = isInClassList(TOGGLE, e.target); | ||
| if (isToggle) { | ||
| buildNewState(TOGGLE, store, e); | ||
| } | ||
| } | ||
| export function deleteTodoItem(e, store) { | ||
| const isDestroy = isInClassList(DESTROY, e.target); | ||
| if (isDestroy) { | ||
| buildNewState(DELETE, store, e); | ||
| } | ||
| } | ||
| export function setEditingMode(e) { | ||
| const isList = e.target.closest("li"); | ||
| if (isList) { | ||
| isList.classList.add(EDITING); | ||
| } | ||
| } | ||
| export function editSelectedTodo(e, store) { | ||
| const isEditing = isInClassList(EDIT, e.target); | ||
| if (isEditing && e.key === "Enter") { | ||
| buildNewState(EDIT, store, e); | ||
| e.target.closest("li").classList.remove(EDITING); | ||
| } | ||
| if (isEditing && e.key === "Escape") { | ||
| const currentValue = $(".label").textContent; | ||
| e.target.value = currentValue; | ||
| e.target.closest("li").classList.remove(EDITING); | ||
| } | ||
| } | ||
|
|
||
| //VIEW HELPER | ||
| export function buildListTodos(store) { | ||
| const { todos, view } = store.getState(); | ||
| return view === "all" ? todos : filterTodos(todos, view); | ||
| } | ||
|
|
||
| //STATE HELPER | ||
| function buildNewState(op, store, e) { | ||
| const OPERATIONS = { | ||
| toggle: toggleTodoStatus, | ||
| delete: deleteTodo, | ||
| edit: editTodo, | ||
| }; | ||
| const prevState = store.getState(); | ||
| const targetId = Number(e.target.closest("li").getAttribute("dataset-id")); | ||
|
|
||
| const newTodos = OPERATIONS[op](prevState, targetId, e); | ||
|
|
||
| const newState = { ...prevState, todos: newTodos }; | ||
| store.setState(newState); | ||
| } | ||
|
|
||
| //TODO - STATUS | ||
| function toggleTodoStatus(prevState, targetId, e) { | ||
| const newStatus = e.target.checked ? "completed" : "active"; | ||
| const newTodos = prevState.todos.map((todo) => { | ||
| if (todo.id === targetId) { | ||
| return { ...todo, status: newStatus }; | ||
| } | ||
| return todo; | ||
| }); | ||
| return newTodos; | ||
| } | ||
| //TODO - DELETE | ||
| function deleteTodo(prevState, targetId) { | ||
| const newTodos = prevState.todos.filter((todo) => { | ||
| return todo.id !== targetId; | ||
| }); | ||
| return newTodos; | ||
| } | ||
|
|
||
| //TODO - UPDATE | ||
| function editTodo(prevState, targetId, e) { | ||
| const newTodos = prevState.todos.map((todo) => { | ||
| if (todo.id === targetId) { | ||
| return { ...todo, content: e.target.value }; | ||
| } | ||
| return todo; | ||
| }); | ||
| return newTodos; | ||
| } |
There was a problem hiding this comment.
helper라는 함수 이름 아래 MOUNT, VIEW, STATE 로직이 다 모여있음. 역할 분리 필요하며 특히 state로직은 state 계층으로
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 요구사항
🎯🎯 심화 요구사항