Add configurations file and improve README #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
judy2k
suggested changes
Oct 25, 2018
README.md
Outdated
| @@ -13,12 +13,14 @@ pipenv shell | |||
|
|
|||
| ## Running It: | |||
|
|
|||
| To run it you'll need to set the following environment variables, either directly, or using Foreman or Envdir: | |||
| To run it you'll need to set the following environment variables. This can be done by running `source config.env` or using Foreman or Envdir: | |||
There was a problem hiding this comment.
Please could you make it clearer in this sentence that they need to modify config.env before sourcing it?
Signed-off-by: Tushar Mittal <[email protected]>
techytushar
force-pushed
the
hacktober
branch
from
a97d991 to
f955440
Compare
|
hey @judy2k, I have updated the changes, please have a look 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a configurations file so that the users can easily set the environment variables and also made some changes to the README