Skip to content
This repository has been archived by the owner on Jan 29, 2022. It is now read-only.

group spans by resources and create batches for each. #68

Merged
merged 2 commits into from
Jun 24, 2020

Conversation

jkwatson
Copy link
Contributor

The span part of implementing #67

Copy link
Contributor

@breedx-nr breedx-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is interesting. I don't have any real feedback on the code itself (looks good to me) but I do wonder about Resource being used as a map key while being abstract and not having explicit equals+hashode.

I also think that if you are interested at this level of performance tuning for the wire, it might also be good to take a look at newrelic/newrelic-telemetry-sdk-java#5 to potentially save round trips.

@jkwatson
Copy link
Contributor Author

Resource is abstract because it uses AutoValue to generate the implementation. This means it has a stable equals/hashcode by design.

@jkwatson
Copy link
Contributor Author

And, yes, we if we implement newrelic/newrelic-telemetry-sdk-java#5 , we can definitely reduce round-trips, as well.

@breedx-nr
Copy link
Contributor

Oh yes autovalue. :). Well, I think we should try this out...thanks!

@breedx-nr breedx-nr merged commit 1ab27bd into master Jun 24, 2020
@breedx-nr breedx-nr deleted the group_span_by_resource branch June 24, 2020 17:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants