Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove version.py and update conda recipe #27

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Conversation

jmborr
Copy link
Member

@jmborr jmborr commented Jul 31, 2024

Short description of the changes:

Remove file version.py and update conda recipe

It was observed that inclusion of packages setuptools and wheel in section host of the conda recipe was necessary to
successfully build the conda package with conda mambabuild

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

References

IBM EWM: 6435

@jmborr jmborr self-assigned this Jul 31, 2024
@jmborr jmborr requested a review from KedoKudo July 31, 2024 20:06
@KedoKudo KedoKudo merged commit 3afe0eb into main Jul 31, 2024
3 checks passed
@KedoKudo KedoKudo deleted the version_file_byebye branch July 31, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants