Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pypi build pipeline #22

Merged
merged 1 commit into from
Jul 5, 2024
Merged

fix pypi build pipeline #22

merged 1 commit into from
Jul 5, 2024

Conversation

KedoKudo
Copy link
Member

@KedoKudo KedoKudo commented Jul 5, 2024

Short description of the changes:

Fix an issue where the PyPI build step does not have the correct Conda env activated.

Long description of the changes:

Add the missing shell login that will force activate the corresponding Conda env for PyPI building.

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

N/A

References

N/A

@KedoKudo KedoKudo self-assigned this Jul 5, 2024
@peterfpeterson peterfpeterson merged commit 72d378c into main Jul 5, 2024
1 check passed
@KedoKudo KedoKudo deleted the fix_pypi_build_ branch October 2, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants