Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing qa and next #36

Merged
merged 5 commits into from
Jan 28, 2025
Merged

Syncing qa and next #36

merged 5 commits into from
Jan 28, 2025

Conversation

KyleQianliMa
Copy link
Collaborator

Short description of the changes:

Long description of the changes:

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

@KyleQianliMa KyleQianliMa requested a review from mpatrou January 28, 2025 18:34
@mpatrou
Copy link
Collaborator

mpatrou commented Jan 28, 2025

the pr should bring qa and next back in sync

@KyleQianliMa KyleQianliMa merged commit 039bd06 into next Jan 28, 2025
5 checks passed
@KyleQianliMa KyleQianliMa deleted the qa branch January 28, 2025 19:43
@KyleQianliMa KyleQianliMa restored the qa branch January 28, 2025 19:44
@KyleQianliMa KyleQianliMa deleted the qa branch January 28, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants