Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
Ref: 6258: [WebMon] Wrong run title shown for HB2C
Everywhere that
StatusCache
is accessed it is done with.latest("timestamp")
except inget_cached_variables
. This is why initially the page is correct but gets updated with incorrect information. Really this issue should not happen but I guess it must be possible.I have changed
get_cached_variables
to sort by name first then newest timestamp, after which we only use the first appearance of that parameter.You can check that this works by starting webmon with docker and add in additional run_title StatusCache (http://localhost/database/dasmon/statuscache/) and check that the newest is always used.
Check all that apply:
References:
Manual test for the reviewer
(Instructions for testing here)
Check list for the reviewer