Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax error in GitHub workflow #187

Merged
merged 1 commit into from
Sep 29, 2024
Merged

Conversation

backmari
Copy link
Contributor

@backmari backmari commented Sep 26, 2024

Description of the changes

Fix syntax error introduced in #185

Check all that apply:

  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests
  • (If applicable) Verified that manual tests requiring the /SNS and /HFIR filesystems pass without fail

References:

  • Links to IBM EWM items:
  • Links to related issues or pull requests:

Manual test for the reviewer

(Instructions for testing here)

Check list for the reviewer

  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.33%. Comparing base (c56942c) to head (7d0e0c0).

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #187   +/-   ##
=======================================
  Coverage   77.33%   77.33%           
=======================================
  Files          51       51           
  Lines        4611     4611           
=======================================
  Hits         3566     3566           
  Misses       1045     1045           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rosswhitfield rosswhitfield merged commit 1adc1a6 into next Sep 29, 2024
4 checks passed
@rosswhitfield rosswhitfield deleted the build_version_tag branch September 29, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants