Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to post-processing agent 3.2.0 #163

Merged
merged 1 commit into from
May 2, 2024
Merged

Conversation

backmari
Copy link
Contributor

@backmari backmari commented May 1, 2024

Short description of the changes:

Update to post-processing agent 3.2.0 to get the right version in the WebMon packages, which are used to deploy the autoreducer to the WebMon test environment: https://code.ornl.gov/sns-hfir-scse/deployments/autoreducer-deploy/-/blob/main/test/docker-compose.yml?ref_type=heads

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

References

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.16%. Comparing base (de87957) to head (bd5dd01).

Additional details and impacted files
@@            Coverage Diff             @@
##             next     #163      +/-   ##
==========================================
- Coverage   77.21%   77.16%   -0.05%     
==========================================
  Files          50       50              
  Lines        4634     4634              
==========================================
- Hits         3578     3576       -2     
- Misses       1056     1058       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@peterfpeterson peterfpeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the urls against those in the post processing agent release v3.2 and they match.

@backmari backmari merged commit 947c0ed into next May 2, 2024
4 checks passed
@backmari backmari deleted the postprocessing_3.2.0 branch May 2, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants