Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Live Data Server domain name #162

Merged
merged 1 commit into from
May 1, 2024
Merged

Conversation

backmari
Copy link
Contributor

Short description of the changes:

Allow the user to override the Live Data Server domain name and port using environment variables. This is to be able to test the new RHEL9 Live Data Server under its temporary domain name.

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

Story 4767: [LiveDataServer] Deploy containerized Live Data Server and test with WebMon test environment
Task 4885: Fix hardcoded "livedata.sns.gov" in WebMon

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.21%. Comparing base (44604d5) to head (ba9d8be).

Additional details and impacted files
@@            Coverage Diff             @@
##             next     #162      +/-   ##
==========================================
+ Coverage   77.16%   77.21%   +0.04%     
==========================================
  Files          50       50              
  Lines        4634     4634              
==========================================
+ Hits         3576     3578       +2     
+ Misses       1058     1056       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jmborr jmborr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks 👌

@backmari backmari merged commit de87957 into next May 1, 2024
4 checks passed
@backmari backmari deleted the live_data_server_domain branch May 1, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants