Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for making changes to the autoreduction configuration form #151

Merged
merged 4 commits into from
Aug 3, 2023

Conversation

backmari
Copy link
Contributor

@backmari backmari commented Aug 2, 2023

This adds a draft for the documentation on how instrument scientists can change the instrument autoreduction configuration page of Web Monitor, for example: https://monitor.sns.gov/reduction/cncs/.

@mpatrou
Copy link

mpatrou commented Aug 2, 2023

It would be helpful to mention the number/names of services involved for the configuration modification and that the communicate with each other.

Copy link
Member

@peterfpeterson peterfpeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great step in adding documentation for webmon. Additional general comment is that the git diffs become a bit easier to read if you use semantic line breaks.

docs/developer/instruction/autoreduction.rst Outdated Show resolved Hide resolved
docs/developer/instruction/autoreduction.rst Outdated Show resolved Hide resolved
docs/developer/instruction/autoreduction.rst Show resolved Hide resolved
docs/developer/instruction/autoreduction.rst Outdated Show resolved Hide resolved
@backmari
Copy link
Contributor Author

backmari commented Aug 3, 2023

@mpatrou @peterfpeterson Thanks for the comments! Also, thanks for the tip on semantic line breaks.

@backmari backmari merged commit 537f4a8 into next Aug 3, 2023
2 checks passed
@backmari backmari deleted the docs_autoreduction branch August 3, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants