Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actually applies the artifical norm this time, bases the A.N. on redu… #489

Draft
wants to merge 3 commits into
base: next
Choose a base branch
from

Conversation

walshmm
Copy link
Collaborator

@walshmm walshmm commented Oct 31, 2024

…ction data as per Malcolm, makes A.N. for EACH group, smoothing field allows for appropriate value >1

Description of work

Explanation of work

To test

Dev testing

CIS testing

# replace with your test script below

Link to EWM item

EWM#<ticket_number>

Verification

  • the author has read the EWM story and acceptance critera
  • the reviewer has read the EWM story and acceptance criteria
  • the reviewer certifies the acceptance criteria below reflect the criteria in EWM

Acceptance Criteria

This list is for ease of reference, and does not replace reading the EWM story as part of the review. Verify this list matches the EWM story before reviewing.

  • acceptance criterion 1
  • acceptance criterion 2

…ction data as per Malcolm, makes A.N. for EACH group, smoothing field allows for appropriate value >1
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 80.76923% with 5 lines in your changes missing coverage. Please review.

Project coverage is 96.42%. Comparing base (8398c8e) to head (688cd89).

Files with missing lines Patch % Lines
src/snapred/backend/recipe/ReductionRecipe.py 50.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next     #489      +/-   ##
==========================================
- Coverage   96.48%   96.42%   -0.06%     
==========================================
  Files          65       65              
  Lines        4832     4843      +11     
==========================================
+ Hits         4662     4670       +8     
- Misses        170      173       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant