Ewm6378 fix full masking in reduction

[darshdinger]

Description of work

Within testing the Reduction Workflow, it was found that errors occur during execution if a masking workspace is used where all data is masked. This causes many group based recipes within ReductionRecipe.py.

Explanation of work

The solution is to skip any algorithm requiring data for fully masked groups, provide a warning to the user, and ensure the workflow completes successfully. The skipped group will impact future reductions using that mask. Logic to handle checking the mask workspace is added to ReductionRecipe.py along with additional logic to handle skipping the group in the case the mask is masking all pixels.

To test

Dev testing

1. Please insure that all unit tests pass.
2. To test the functionality within SNAPRed UI, please follow the steps listed:

• Within your local Calibration directory, delete all of your states, start SNAPRed and run a diffraction calibration and a normalization for run 58882. You can use the following inputs:

diffraction calibration
run number: 58882
convergence threshold: 0.1
bins across peak width: 10
sample: Silicon_NIST_640D_001
grouping: Column

normalization:
run number: 58882
background run number: 58810
sample: Silicon_NIST_640D_001
grouping: Column

• Use the diffcal_masking_script.py within mantid workbench to produce a masking workspace where all pixels are masked.

NOTE: This diffcal_masking_script.py is broken! I only fixed up till L 133 to get the logic to produce a mask that can be used in testing. I have not fixed the whole cis_script as this is out of scope for this story.

• Then before saving the mask to the disk, check the workspace data. All Y values should be 1 if you created the mask correctly. Rename it to MaskWorkspace_2 and then save it to a location easily accessible. I would recommend the Desktop.
• Open SNAPRed once again, using the load button on the main panel, load the MaskWorkspace_2 so that it is in ADS.
• Within the Reduction Workflow, use run number 58882, and select MaskWorkspace_2. And run.
• Notice at the end of the workflow, a warning box pops up. Scrolling down, you will see that errors are displayed to notify user.

CIS testing

Same as dev testing but don't worry about unit tests.

Link to EWM item

EWM#6378

Verification

• the author has read the EWM story and acceptance critera
• the reviewer has read the EWM story and acceptance criteria
• the reviewer certifies the acceptance criteria below reflect the criteria in EWM

Acceptance Criteria

This list is for ease of reference, and does not replace reading the EWM story as part of the review. Verify this list matches the EWM story before reviewing.

• acceptance criterion 1
• acceptance criterion 2

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.53%. Comparing base (6e88017) to head (b5ac8fe).
Report is 1 commits behind head on next.

Additional details and impacted files

@@            Coverage Diff             @@
##             next     #479      +/-   ##
==========================================
+ Coverage   96.52%   96.53%   +0.01%     
==========================================
  Files          63       63              
  Lines        4488     4503      +15     
==========================================
+ Hits         4332     4347      +15     
  Misses        156      156              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dlcaballero16]

Tested and verified Reduction workflow was able to complete even though full mask was applied. Warning messages showed as expected.