Ewm7115 fix remove event background undersampling #456
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #456 +/- ##
=======================================
Coverage 96.53% 96.53%
=======================================
Files 63 63
Lines 4503 4503
=======================================
Hits 4347 4347
Misses 156 156 ☔ View full report in Codecov by Sentry. |
| "Converting TOF data to MatrixWorkspace...", | ||
| InputWorkspace=self.wsTOF, | ||
| OutputWorkspace=self.wsTOF, | ||
| self.mantidSnapper.ConvertToEventWorkspace( |
There was a problem hiding this comment.
What if self.wsTOF is a histogram workspace?
There was a problem hiding this comment.
It can't be one. The only accepted input workspace type is required to be MatrixWorkspacePropery.
There was a problem hiding this comment.
But MatrixWorkspaces can hold their data in either event or histogram format. That's why the isHistogramData method exists for MatrixWorkspaces.
There was a problem hiding this comment.
I would suggest using the HistogramValidator with False to make sure this is event data, if the expectation is truly that it will only be event data.
|
This was handled in another PR 472 that Reece merged. |
darshdinger
force-pushed
the
ewm7115-fix-remove-event-background-undersampling
branch
from
0237e6d
to
a1aa66f
Compare
darshdinger
deleted the
ewm7115-fix-remove-event-background-undersampling
branch
* Final update * Updated tests. * Final update, tested and functional. Removed undersampling * Update tests to reflect changes in PixelDiffractionCalibration
Description of work
This work is to facilitate the resolution of a defect in this implementation. The issue resulted in "under-binning" of the data.
Explanation of work
The logic implemented:
To test
CIS testing
Please follow the same steps listed within PR 449.
Link to EWM item
EWM # 7115