Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

substitute "sample" with "peak" #17

Merged
merged 2 commits into from
Oct 30, 2024
Merged

substitute "sample" with "peak" #17

merged 2 commits into from
Oct 30, 2024

Conversation

jmborr
Copy link
Member

@jmborr jmborr commented Oct 30, 2024

Simply substitute the concept of sample with peak, in the context of multiple intensity peaks in a given run. For instance, when multiple samples are present in a given experiment and the samples scatter at different angles, more than one
intensity peak is observed

Description of work:

Check all that apply:

  • release notes not needed
  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests

References:

  • Links to IBM EWM items: 7592 (parent 5896)

Manual test for the reviewer

(Instructions for testing here)

Check list for the reviewer

  • release notes
    updated, or an explanation is provided as to why release notes are unnecessary
  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

in the context of multiple intensity peaks in a given run. For instance, when multiple samples are present in a given experiment

Signed-off-by: Jose Borreguero <[email protected]>
@jmborr jmborr self-assigned this Oct 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 82.63473% with 29 lines in your changes missing coverage. Please review.

Project coverage is 75.41%. Comparing base (bc09361) to head (00263ff).
Report is 3 commits behind head on next.

Files with missing lines Patch % Lines
src/mr_reduction/peak_finding.py 35.13% 24 Missing ⚠️
src/mr_reduction/runpeak.py 94.00% 3 Missing ⚠️
src/mr_reduction/reflectivity_merge.py 95.65% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             next      #17   +/-   ##
=======================================
  Coverage   75.41%   75.41%           
=======================================
  Files          18       18           
  Lines        2209     2209           
=======================================
  Hits         1666     1666           
  Misses        543      543           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Remove instructions and checklist items related to executing SNS and HFIR filesystem-dependent tests. These steps are no longer necessary as they are not part of the current testing framework.

Signed-off-by: Jose Borreguero <[email protected]>
@jmborr jmborr merged commit f80fafc into next Oct 30, 2024
1 check passed
@jmborr jmborr deleted the from_sample_to_peak_suffix branch October 30, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants