Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add finddata conda package as dependency #16

Merged
merged 4 commits into from
Aug 12, 2024
Merged

Add finddata conda package as dependency #16

merged 4 commits into from
Aug 12, 2024

Conversation

jmborr
Copy link
Member

@jmborr jmborr commented Aug 12, 2024

Description of work:

use the new finddata conda package 0.10

Check all that apply:

  • added release notes
    (if not, provide an explanation in the work description)
  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests
  • Verified that tests requiring the /SNS and /HFIR filesystems pass without fail

References:

  • Links to IBM EWM items: 6630

Check list for the reviewer

  • release notes
    updated, or an explanation is provided as to why release notes are unnecessary
  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Execution of tests requiring the /SNS and /HFIR filesystems

It is strongly encouraged that the reviewer runs the following tests in their local machine
because these tests are not run by the GitLab CI. It is assumed that the reviewer has the /SNS and /HFIR filesystems
remotely mounted in their machine.

cd /path/to/my/local/mr_reduction/repo/
git fetch origin merge-requests/<MERGE_REQUEST_NUMBER>/head:mr<MERGE_REQUEST_NUMBER>
git switch mr<MERGE_REQUEST_NUMBER>
conda activate <my_mr_reduction_environment>
pytest -m mount_eqsans ./tests/unit/ ./tests/integration/

In the above code snippet, substitute <MERGE_REQUEST_NUMBER> for the actual merge request number. Also substitute
<my_mr_reduction_environment> with the name of the conda environment you use for development. It is critical that
you have installed the repo in editable mode with pip install -e . or conda develop .

Signed-off-by: Jose Borreguero <[email protected]>
@jmborr jmborr self-assigned this Aug 12, 2024
Signed-off-by: Jose Borreguero <[email protected]>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.41%. Comparing base (dd795ac) to head (4abcc7c).

Additional details and impacted files
@@           Coverage Diff           @@
##             next      #16   +/-   ##
=======================================
  Coverage   75.41%   75.41%           
=======================================
  Files          18       18           
  Lines        2209     2209           
=======================================
  Hits         1666     1666           
  Misses        543      543           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmborr jmborr merged commit bc09361 into next Aug 12, 2024
1 check passed
@jmborr jmborr deleted the finddata_conda branch August 12, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants