Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update mantid version in the conda recipe #12

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

jmborr
Copy link
Member

@jmborr jmborr commented Jul 16, 2024

Description of the changes

Manual test for the reviewer

Check list for the reviewer

  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Execution of tests requiring the /SNS and /HFIR filesystems

It is strongly encouraged that the reviewer runs the following tests in their local machine
because these tests are not run by the GitLab CI. It is assumed that the reviewer has the /SNS and /HFIR filesystems
remotely mounted in their machine.

cd /path/to/my/local/mr_reduction/repo/
git fetch origin merge-requests/<MERGE_REQUEST_NUMBER>/head:mr<MERGE_REQUEST_NUMBER>
git switch mr<MERGE_REQUEST_NUMBER>
conda activate <my_mr_reduction_environment>
pytest -m mount_eqsans ./tests/unit/ ./tests/integration/

In the above code snippet, substitute <MERGE_REQUEST_NUMBER> for the actual merge request number. Also substitute
<my_mr_reduction_environment> with the name of the conda environment you use for development. It is critical that
you have installed the repo in editable mode with pip install -e . or conda develop .

Check list for the author

  • I have added tests for my changes
  • I have updated the documentation accordingly
  • I ran the tests requiring the /SNS and /HFIR filesystems
  • I'm including a link to IBM EWM Story or Defect

Check list for the pull request

  • source refactored/incremented
  • tests for my changes
  • updated the documentation accordingly

References

Signed-off-by: Jose Borreguero <[email protected]>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.38%. Comparing base (8094014) to head (155fea5).

Additional details and impacted files
@@           Coverage Diff           @@
##             next      #12   +/-   ##
=======================================
  Coverage   75.38%   75.38%           
=======================================
  Files          18       18           
  Lines        2206     2206           
=======================================
  Hits         1663     1663           
  Misses        543      543           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmborr jmborr merged commit 26b7640 into next Jul 16, 2024
1 check passed
@jmborr jmborr deleted the update_conda_recipe branch July 16, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants