Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing Framework and initial tests #2

Open
wants to merge 19 commits into
base: next
Choose a base branch
from
Open

Testing Framework and initial tests #2

wants to merge 19 commits into from

Conversation

mpatrou
Copy link
Collaborator

@mpatrou mpatrou commented Nov 1, 2024

It includes the testing framework, tests and some other improvements

Short description of the changes:

It includes:

  • pytest configurations
  • initial tests for main window, application start, version, configuration settings
  • argument parsing

Long description of the changes:

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.69%. Comparing base (1978169) to head (2edbc71).

Files with missing lines Patch % Lines
src/hyspecplanningtools/hyspecplanningtools.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            next       #2       +/-   ##
==========================================
+ Coverage   1.60%   63.69%   +62.09%     
==========================================
  Files          4        8        +4     
  Lines        125      157       +32     
==========================================
+ Hits           2      100       +98     
+ Misses       123       57       -66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants