Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Settings in the Code #1

Merged
merged 23 commits into from
Oct 29, 2024
Merged

Initial Settings in the Code #1

merged 23 commits into from
Oct 29, 2024

Conversation

mpatrou
Copy link
Collaborator

@mpatrou mpatrou commented Oct 28, 2024

Short description of the changes:

Initial Settings in the code

Long description of the changes:

The changes include:

  • adding hyspecplanningtools as package name in every reference
  • mantid logger is replaced with python logger
  • environment is updated with some initial dependencies
  • gitignore update
  • github actions updates
  • notebooks/ removed
  • scripts added with initial prototype/script and readme on how to run it
  • pre-commit updates to exclude scripts
  • code coverage and pre-commit related configurations
  • badges for github action and code coverage
  • README updates on installation process

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

Create the environment
conda env create

Activate the environment
conda activate hyspecplanningtools_dev

Install the package
pip install -e .

Start
hyspecplanningtools

  1. To run the the prototype script
    python ./scripts/show_polarization_plots.py

  2. To run the existing test
    pytest

References

[PPT] Set-up Repository for polarization planning tool

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@mpatrou mpatrou merged commit 1978169 into next Oct 29, 2024
2 checks passed
@mpatrou mpatrou deleted the initial_settings branch October 29, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants