-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle different number of classes between y_true and y_pred #12
base: master
Are you sure you want to change the base?
Handle different number of classes between y_true and y_pred #12
Conversation
…es_between_y_true_and_y_pred
…true_and_y_pred' of github.com:SomeoneInParticular/modular_optuna_ml into jv/experimental-fix_different_num_of_classes_between_y_true_and_y_pred
Is this finalized? Or are you still testing it in-draft? |
I believe it can be tested by you and merged |
Apologies for the delay, wanted to really dig through everything before accepting this PR. I don't think this is going to work long-term, as there is an edge case this does not account for currently. Namely, where their are unique classes in both the training and testing data. For example, if training has classes [ This is actually an issue with most of the supervised categorical metrics at the moment, and as such we will need to look into a more universal solution here... I'll dig into it later this week, but for now I don't think its smart to push this PR. |
…es_between_y_true_and_y_pred
Very good point! Okay, let's not processed with merging. |
Handle
ValueError: y_true and y_pred contain different number of classes