Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MacOS versions in CI #3102

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bump MacOS versions in CI #3102

wants to merge 1 commit into from

Conversation

JCGoran
Copy link
Contributor

@JCGoran JCGoran commented Oct 1, 2024

MacOS 12 is unsupported as of 16/09/2024.

Copy link

sonarcloud bot commented Oct 1, 2024

Copy link

✔️ 307fd65 -> Azure artifacts URL

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.90%. Comparing base (95cc05b) to head (307fd65).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3102   +/-   ##
=======================================
  Coverage   66.90%   66.90%           
=======================================
  Files         572      572           
  Lines      106671   106671           
=======================================
+ Hits        71364    71367    +3     
+ Misses      35307    35304    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JCGoran JCGoran marked this pull request as ready for review October 2, 2024 11:04
@JCGoran JCGoran requested a review from alkino October 2, 2024 11:04
@@ -85,7 +85,7 @@ stages:
- job: 'MacOSWheels'
timeoutInMinutes: 60
pool:
vmImage: 'macOS-12'
vmImage: 'macOS-13'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't check the toolchain versions on MacOS-12 and if it's worth testing a bit longer, but it's LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants