Remove unused cvodematsol
#3064
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ a8d3b38 -> Azure artifacts URL |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3064 +/- ##
=======================================
Coverage 67.26% 67.26%
=======================================
Files 571 571
Lines 104885 104875 -10
=======================================
- Hits 70550 70546 -4
+ Misses 34335 34329 -6 ☔ View full report in Codecov by Sentry. |
|
Better to ask first to @nrnhines |
nrnhines
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lookup to
cvodematsolonly appears in these 2 lines in the code, and nowhere else. It also appears in only 2 commits in the entire history, 013b69a and 1f65637.Furthermore, if one does actually define a symbol like
cvodematsol(for instance, aRANGE cvodematsolwill do), then NOCMODL will generate broken cpp files. There are no mod files using it in modelDB, so I think it's safe to remove this check.