Have NMODL generate the solver header files. #2994
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than dumping the complete headers, dump the crout and newton solvers in a `solver/` directory. CI_BRANCHES:NMODL_BRANCH=dump-solvers-separately
This comment has been minimized.
This comment has been minimized.
alkino
approved these changes
Jul 16, 2024
This comment has been minimized.
This comment has been minimized.
|
✔️ 1b39d64 -> Azure artifacts URL |
|
✔️ 77a67a4 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
|
✔️ 2c0f3c8 -> Azure artifacts URL |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2994 +/- ##
==========================================
- Coverage 67.29% 67.28% -0.02%
==========================================
Files 572 572
Lines 104961 104974 +13
==========================================
- Hits 70632 70627 -5
- Misses 34329 34347 +18 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
|
|
✔️ 059f578 -> Azure artifacts URL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than dumping the complete headers, dump the crout and newton
solvers in a
solver/directory.CI_BRANCHES:NMODL_BRANCH=dump-solvers-separately