Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beginning of nb #2956

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

beginning of nb #2956

wants to merge 2 commits into from

Conversation

alkino
Copy link
Member

@alkino alkino commented Jul 4, 2024

No description provided.

Nicolas Cornu and others added 2 commits July 3, 2024 18:38
Copy link

sonarcloud bot commented Jul 4, 2024

Copy link

✔️ c88b8df -> Azure artifacts URL

}
nb::tuple args_(args);
if (args_.size()) {
req = nb::cast<int>(args_[0]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the argument is not int the result will be different (return NULL vs Exception). Will it work the same from the user side?

@ferdonline
Copy link
Member

ferdonline commented Jul 8, 2024

IMO the big advantage of nanobind is when we can get rid of the manual ref-counting, or simplify the code significantly thanks to the new API. If the simplification is not that significant it might be even better to leave as is, due to the risk of regressions.
IMO the big advantage with nanobind would be, for static types (like Section and Segment) we can use full class bindings (similar to pytbind11 bindings). For the dynamic Hoc object, we can hopefully do significant simplifications without a full rewrite using the object api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants