Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hasAdjacentKeywordInEvaluationPath optimisation #1124

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

justin-tay
Copy link
Contributor

Closes #1123

This fixes the incorrect logic for determining if there is a change in the instance location.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.12%. Comparing base (48ca3c2) to head (ee91182).
Report is 60 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1124      +/-   ##
============================================
- Coverage     78.90%   78.12%   -0.78%     
- Complexity     1965     2071     +106     
============================================
  Files           172      201      +29     
  Lines          6352     6881     +529     
  Branches       1255     1262       +7     
============================================
+ Hits           5012     5376     +364     
- Misses          867     1034     +167     
+ Partials        473      471       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevehu stevehu merged commit 8664d3c into networknt:master Oct 30, 2024
4 checks passed
@Whathecode
Copy link
Contributor

That was quick! Great work, @justin-tay !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unevaluatedProperties not evaluating properties stemming from $ref schemas loaded through nested allOf
4 participants