Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix schema location with hash in fragment #1075

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

justin-tay
Copy link
Contributor

This fixes the case where the schema location has a # in the fragment for example https://example.com/example.yaml#/paths/~1subscribe/post/callbacks/myEvent/{request.body#~1callbackUrl}/post/requestBody/content/application~1json/schema.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.94%. Comparing base (48ca3c2) to head (38a0b3b).
Report is 40 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1075      +/-   ##
============================================
- Coverage     78.90%   77.94%   -0.96%     
- Complexity     1965     2049      +84     
============================================
  Files           172      198      +26     
  Lines          6352     6851     +499     
  Branches       1255     1255              
============================================
+ Hits           5012     5340     +328     
- Misses          867     1032     +165     
- Partials        473      479       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevehu stevehu merged commit 7a58366 into networknt:master Jun 24, 2024
4 checks passed
@justin-tay justin-tay deleted the schemalochash branch June 25, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants