Skip to content

Commit

Permalink
added declare(strict_types=1);
Browse files Browse the repository at this point in the history
  • Loading branch information
@kukulich @dg
kukulich authored and dg committed Jan 9, 2017
1 parent ac2ae72 commit eb5275c
Show file tree
Hide file tree
Showing 149 changed files with 304 additions and 2 deletions.
2 changes: 2 additions & 0 deletions src/Iterators/CachingIterator.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
* Copyright (c) 2004 David Grudl (https://davidgrudl.com)
*/

declare(strict_types=1);

namespace Nette\Iterators;

use Nette;
Expand Down
2 changes: 2 additions & 0 deletions src/Iterators/Mapper.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
* Copyright (c) 2004 David Grudl (https://davidgrudl.com)
*/

declare(strict_types=1);

namespace Nette\Iterators;

use Nette;
Expand Down
2 changes: 2 additions & 0 deletions src/Utils/ArrayHash.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
* Copyright (c) 2004 David Grudl (https://davidgrudl.com)
*/

declare(strict_types=1);

namespace Nette\Utils;

use Nette;
Expand Down
2 changes: 2 additions & 0 deletions src/Utils/ArrayList.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
* Copyright (c) 2004 David Grudl (https://davidgrudl.com)
*/

declare(strict_types=1);

namespace Nette\Utils;

use Nette;
Expand Down
2 changes: 2 additions & 0 deletions src/Utils/Arrays.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
* Copyright (c) 2004 David Grudl (https://davidgrudl.com)
*/

declare(strict_types=1);

namespace Nette\Utils;

use Nette;
Expand Down
2 changes: 2 additions & 0 deletions src/Utils/Callback.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
* Copyright (c) 2004 David Grudl (https://davidgrudl.com)
*/

declare(strict_types=1);

namespace Nette\Utils;

use Nette;
Expand Down
2 changes: 2 additions & 0 deletions src/Utils/DateTime.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
* Copyright (c) 2004 David Grudl (https://davidgrudl.com)
*/

declare(strict_types=1);

namespace Nette\Utils;

use Nette;
Expand Down
2 changes: 2 additions & 0 deletions src/Utils/FileSystem.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
* Copyright (c) 2004 David Grudl (https://davidgrudl.com)
*/

declare(strict_types=1);

namespace Nette\Utils;

use Nette;
Expand Down
2 changes: 2 additions & 0 deletions src/Utils/Html.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
* Copyright (c) 2004 David Grudl (https://davidgrudl.com)
*/

declare(strict_types=1);

namespace Nette\Utils;

use Nette;
Expand Down
2 changes: 2 additions & 0 deletions src/Utils/IHtmlString.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
* Copyright (c) 2004 David Grudl (https://davidgrudl.com)
*/

declare(strict_types=1);

namespace Nette\Utils;


Expand Down
2 changes: 2 additions & 0 deletions src/Utils/ITranslator.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
* Copyright (c) 2004 David Grudl (https://davidgrudl.com)
*/

declare(strict_types=1);

namespace Nette\Localization;


Expand Down
2 changes: 2 additions & 0 deletions src/Utils/Image.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
* Copyright (c) 2004 David Grudl (https://davidgrudl.com)
*/

declare(strict_types=1);

namespace Nette\Utils;

use Nette;
Expand Down
2 changes: 2 additions & 0 deletions src/Utils/Json.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
* Copyright (c) 2004 David Grudl (https://davidgrudl.com)
*/

declare(strict_types=1);

namespace Nette\Utils;

use Nette;
Expand Down
2 changes: 2 additions & 0 deletions src/Utils/Object.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
* Copyright (c) 2004 David Grudl (https://davidgrudl.com)
*/

declare(strict_types=1);

namespace Nette;

use Nette;
Expand Down
2 changes: 2 additions & 0 deletions src/Utils/ObjectMixin.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
* Copyright (c) 2004 David Grudl (https://davidgrudl.com)
*/

declare(strict_types=1);

namespace Nette\Utils;

use Nette;
Expand Down
2 changes: 2 additions & 0 deletions src/Utils/Paginator.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
* Copyright (c) 2004 David Grudl (https://davidgrudl.com)
*/

declare(strict_types=1);

namespace Nette\Utils;

use Nette;
Expand Down
2 changes: 2 additions & 0 deletions src/Utils/Random.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
* Copyright (c) 2004 David Grudl (https://davidgrudl.com)
*/

declare(strict_types=1);

namespace Nette\Utils;

use Nette;
Expand Down
2 changes: 2 additions & 0 deletions src/Utils/Reflection.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
* Copyright (c) 2004 David Grudl (https://davidgrudl.com)
*/

declare(strict_types=1);

namespace Nette\Utils;

use Nette;
Expand Down
2 changes: 2 additions & 0 deletions src/Utils/SmartObject.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
* Copyright (c) 2004 David Grudl (https://davidgrudl.com)
*/

declare(strict_types=1);

namespace Nette;

use Nette\Utils\Callback;
Expand Down
2 changes: 2 additions & 0 deletions src/Utils/StaticClass.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
* Copyright (c) 2004 David Grudl (https://davidgrudl.com)
*/

declare(strict_types=1);

namespace Nette;


Expand Down
2 changes: 2 additions & 0 deletions src/Utils/Strings.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
* Copyright (c) 2004 David Grudl (https://davidgrudl.com)
*/

declare(strict_types=1);

namespace Nette\Utils;

use Nette;
Expand Down
2 changes: 2 additions & 0 deletions src/Utils/Validators.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
* Copyright (c) 2004 David Grudl (https://davidgrudl.com)
*/

declare(strict_types=1);

namespace Nette\Utils;

use Nette;
Expand Down
2 changes: 2 additions & 0 deletions src/Utils/exceptions.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
* Copyright (c) 2004 David Grudl (https://davidgrudl.com)
*/

declare(strict_types=1);

namespace Nette;


Expand Down
2 changes: 2 additions & 0 deletions tests/Iterators/CachingIterator.basic.phpt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
* Test: Nette\Iterators\CachingIterator basic usage.
*/

declare(strict_types=1);

use Nette\Iterators;
use Tester\Assert;

Expand Down
2 changes: 2 additions & 0 deletions tests/Iterators/CachingIterator.construct.phpt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
* Test: Nette\Iterators\CachingIterator constructor.
*/

declare(strict_types=1);

use Nette\Iterators;
use Tester\Assert;

Expand Down
2 changes: 2 additions & 0 deletions tests/Iterators/CachingIterator.width.phpt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
* Test: Nette\Iterators\CachingIterator width.
*/

declare(strict_types=1);

use Nette\Iterators;
use Tester\Assert;

Expand Down
2 changes: 2 additions & 0 deletions tests/Iterators/Mapper.phpt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
* Test: Nette\Iterators\Mapper
*/

declare(strict_types=1);

use Nette\Iterators;
use Tester\Assert;

Expand Down
2 changes: 2 additions & 0 deletions tests/Utils/ArrayHash.phpt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
* Test: Nette\Utils\ArrayHash basic usage.
*/

declare(strict_types=1);

use Nette\Utils\ArrayHash;
use Tester\Assert;

Expand Down
2 changes: 2 additions & 0 deletions tests/Utils/ArrayList.phpt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
* Test: Nette\Utils\ArrayList basic usage.
*/

declare(strict_types=1);

use Nette\Utils\ArrayList;
use Tester\Assert;

Expand Down
2 changes: 2 additions & 0 deletions tests/Utils/Arrays.associate().error.phpt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
* Test: Nette\Utils\Arrays::associate()
*/

declare(strict_types=1);

use Nette\Utils\Arrays;
use Tester\Assert;

Expand Down
2 changes: 2 additions & 0 deletions tests/Utils/Arrays.associate().phpt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
* Test: Nette\Utils\Arrays::associate()
*/

declare(strict_types=1);

use Nette\Utils\Arrays;
use Nette\Utils\DateTime;
use Tester\Assert;
Expand Down
2 changes: 2 additions & 0 deletions tests/Utils/Arrays.every().phpt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
* Test: Nette\Utils\Arrays::every()
*/

declare(strict_types=1);

use Nette\Utils\Arrays;
use Tester\Assert;

Expand Down
2 changes: 2 additions & 0 deletions tests/Utils/Arrays.flatten().phpt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
* Test: Nette\Utils\Arrays::flatten()
*/

declare(strict_types=1);

use Nette\Utils\Arrays;
use Tester\Assert;

Expand Down
2 changes: 2 additions & 0 deletions tests/Utils/Arrays.get().phpt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
* Test: Nette\Utils\Arrays::get()
*/

declare(strict_types=1);

use Nette\Utils\Arrays;
use Tester\Assert;

Expand Down
2 changes: 2 additions & 0 deletions tests/Utils/Arrays.getRef().phpt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
* Test: Nette\Utils\Arrays::getRef()
*/

declare(strict_types=1);

use Nette\Utils\Arrays;
use Tester\Assert;

Expand Down
2 changes: 2 additions & 0 deletions tests/Utils/Arrays.grep().errors.phpt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
* Test: Nette\Utils\Arrays::grep() errors.
*/

declare(strict_types=1);

use Nette\Utils\Arrays;
use Tester\Assert;

Expand Down
2 changes: 2 additions & 0 deletions tests/Utils/Arrays.grep().phpt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
* Test: Nette\Utils\Arrays::grep()
*/

declare(strict_types=1);

use Nette\Utils\Arrays;
use Tester\Assert;

Expand Down
2 changes: 2 additions & 0 deletions tests/Utils/Arrays.insertBefore().phpt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
* Test: Nette\Utils\Arrays::insertBefore() & insertAfter()
*/

declare(strict_types=1);

use Nette\Utils\Arrays;
use Tester\Assert;

Expand Down
2 changes: 2 additions & 0 deletions tests/Utils/Arrays.isList.phpt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
* Test: Nette\Utils\Arrays::isList()
*/

declare(strict_types=1);

use Nette\Utils\Arrays;
use Tester\Assert;

Expand Down
2 changes: 2 additions & 0 deletions tests/Utils/Arrays.map().phpt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
* Test: Nette\Utils\Arrays::map()
*/

declare(strict_types=1);

use Nette\Utils\Arrays;
use Tester\Assert;

Expand Down
2 changes: 2 additions & 0 deletions tests/Utils/Arrays.normalize.phpt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
* Test: Nette\Utils\Arrays::searchKey()
*/

declare(strict_types=1);

use Nette\Utils\Arrays;
use Tester\Assert;

Expand Down
2 changes: 2 additions & 0 deletions tests/Utils/Arrays.pick().phpt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
* Test: Nette\Utils\Arrays::pick()
*/

declare(strict_types=1);

use Nette\Utils\Arrays;
use Tester\Assert;

Expand Down
2 changes: 2 additions & 0 deletions tests/Utils/Arrays.renameKey().phpt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
* Test: Nette\Utils\Arrays::renameKey()
*/

declare(strict_types=1);

use Nette\Utils\Arrays;
use Tester\Assert;

Expand Down
2 changes: 2 additions & 0 deletions tests/Utils/Arrays.searchKey().phpt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
* Test: Nette\Utils\Arrays::searchKey()
*/

declare(strict_types=1);

use Nette\Utils\Arrays;
use Tester\Assert;

Expand Down
Loading

3 comments on commit eb5275c

@JanTvrdik
Copy link
Contributor

@JanTvrdik JanTvrdik commented on eb5275c Jan 10, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO this should certainly be declare(strict_types = 1); to be consistent with used coding style.

Placing the declare on the same line as <?php is my personal preference (we use strict types in @manGoweb for quite some time).

<?php declare(strict_types = 1);

@dg
Copy link
Member

@dg dg commented on eb5275c Jan 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or even more consistent: declare (strict_types = 1);

@dg
Copy link
Member

@dg dg commented on eb5275c Jan 10, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, Nette has no coding style for declare construct, so I will use the same style as PHP documentation.

<?php declare(strict_types = 1);

I hope that once it will be simplified to <?phps or removed at all.

Please sign in to comment.