Request: In case of CLI method should be CLI too. #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
HTTP method CLI doesn't exist. |
|
I don't know how to better represent this (if at all). When obtaining the current Request from the DI, it should be possible to verify that the Request was created artificially in CLI mode and is not a real request. In that case, I can't rely on a number of things, such as URLs. What do you think? |
|
In a strict way - an HTTP request can be automatically created only via HTTP protocol so exception is more accurate. In practice - I'm not sure. |
dg
force-pushed
the
master
branch
10 times, most recently
from
5ace0ce to
3affe3a
Compare
dg
force-pushed
the
master
branch
4 times, most recently
from
6ee31b8 to
4f4a403
Compare
dg
force-pushed
the
master
branch
4 times, most recently
from
a8895b6 to
9409a5f
Compare
dg
force-pushed
the
master
branch
5 times, most recently
from
7b7f9ff to
78bee95
Compare
dg
force-pushed
the
master
branch
6 times, most recently
from
da24b94 to
540335c
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
e7c7e2d to
bf945f3
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
9a14e6e to
a20fb8f
Compare
dg
force-pushed
the
master
branch
5 times, most recently
from
55488bd to
2042d2e
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
4960652 to
5e67add
Compare
dg
force-pushed
the
master
branch
5 times, most recently
from
689f4ae to
33aae19
Compare
dg
force-pushed
the
master
branch
4 times, most recently
from
09923de to
02ae846
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of obtaining a service for an Http Request in CLI mode, it does not make sense for the call method to be GET when no request exists.
I think Request should either throw an exception that cannot be used in a CLI context, or it should return a special CLI method.
Current behavior looks illogical:
Thanks.