This repository has been archived by the owner on May 22, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 35
feat!: output pure ESM for .mjs
files
#1198
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardoboucas
added
the
type: feature
code contributing to the implementation of a feature and/or user facing functionality
label
Sep 5, 2022
eduardoboucas
changed the title
feat!: output pure ESM for .mjs files
feat!: output pure ESM for Sep 5, 2022
.mjs
files
⏱ Benchmark resultsComparing with e15da2c largeDepsEsbuild: 8.4s⬆️ 13.71% increase vs. e15da2c
Legend
largeDepsNft: 44.2s⬆️ 20.77% increase vs. e15da2c
Legend
largeDepsZisi: 1m 0.2s⬆️ 10.75% increase vs. e15da2c
Legend
|
jackiewmacharia
approved these changes
Sep 5, 2022
khendrikse
approved these changes
Sep 5, 2022
This was referenced Sep 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
type: feature
code contributing to the implementation of a feature and/or user facing functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, ESM functions are transpiled down to CommonJS. With this PR, we'll output pure ESM functions when:
.mjs
extension, andzisi_pure_esm_mjs
feature flag is onPart of #750.