feat: add getDeployStore method
#68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for blobs-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
the
type: feature
lukasholzer
approved these changes
Oct 18, 2023
| const string = await deployStore.get(key) | ||
| expect(string).toBe(value) | ||
|
|
||
| const stream = await deployStore.get(key, { type: 'stream' }) |
There was a problem hiding this comment.
we could make the types for deployStore.get better that if the type is stream it will return a NodeJS.ReadableStream but we can do this in a follow up
There was a problem hiding this comment.
That's already the case:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this pull request solving?
Adds a
getDeployStoremethod that can be used to create a deploy-scoped store. It can also read the deploy ID from the context object in the environment.More information in the updated README.