feat: export commonjs and esm from package #59
Conversation
✅ Deploy Preview for blobs-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
the
type: feature
There was a problem hiding this comment.
The approach looks good. These ESM migrations typically break something, so i'd encourage you to publish this as a prerelease first (or yolo it, as you prefer).
Just calling out that this change starts bundling in all dependencies. Shouldn't be a problem as long as the dependencies aren't big, but this will probably break for more involved dependencies, like when there's native code. (but I think esbuild was already doing that before? plus this needs to work in edge functions as well.)
|
On the bundling part you are completely right. Next goal is to get rid of https://publint.dev/@netlify/[email protected]
and types as well: https://arethetypeswrong.github.io/?p=%40netlify%2Fblobs%402.1.0-rc.2
|
| import { rm } from 'node:fs/promises' | ||
| import { argv } from 'process' | ||
|
|
||
| // eslint-disable-next-line import/no-extraneous-dependencies |
There was a problem hiding this comment.
Why is this an extraneous dependency?
There was a problem hiding this comment.
because it's a dev dependency 🤷 the lint rule is crazy.
Eslint does not know that we don't need it as dependency:
'tsup' should be listed in the project's dependencies. Run 'npm i -S tsup' to add iteslintimport/no-extraneous-dependencies
🎉 Thanks for sending this pull request! 🎉
To support our old CommonJS packages like the next-runtime export both commonjs and ESM.
Full discussion is here: https://netlify.slack.com/archives/C05DNT7CLFK/p1696930990204579
cc @ascorbic @orinokai @pieh