Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Multicast Routing and Igmp tables. #727

Closed

Conversation

scetron
Copy link

@scetron scetron commented May 9, 2022

Test inclusion requirements

In case the PR contains an enhancement or a new platform/service support, some tests have to be added for the new functionality:

  • any fix or enhancement SHOULD include relevant new tests or test updates, if any tests need updating.
  • a new platform support MUST include the relevant input files similar to what we have in tests/integration/sqcmds/-input directories, along with the relevant tests in the tests/integration/sqcmds/-samples dir. That list MUST include the all.yml file fully filled out.
  • any new service (or table) addition MUST include comments about what network OS are supported (along with version) with this command along with test samples for those platforms and input files in the *-input dir

For additional information about tests, follow this link

Related Issue

Fixes #377

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

New Behavior

To add the collection of the multicast routing table and igmp interface information to develop an idea of the state of multicast across the network.

Contrast to Current Behavior

No multicast specific command output is collected.

Discussion: Benefits and Drawbacks

Make the entire network more visible and open the usage of Suzie Q to more networks that may rely on multicast.

Changes to the Documentation

Development notes for adding a new Service will be added in a Separate PR.

Proposed Release Note Entry

Add Mroute and Igmp tables for EOS, NXOS, and JUNOS.

Comments

Include additional comments about the this pull request

Double Check

  • I have read the comments and followed the CONTRIBUTING.md.

  • I have explained my PR according to the information in the comments or in a linked issue.

  • My PR source branch is created from the develop branch.

  • My PR targets the develop branch.

  • All my commits have --signoff applied

  • All test data updated

  • EOS Support for Mroute

  • EOS Support for IGMP

  • NXOS Support for Mroute

  • NXOS Support for IGMP

  • JUNOS Support for Mroute

  • JUNOS Support for IGMP

@scetron scetron marked this pull request as draft May 9, 2022 15:41
@scetron scetron closed this Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multicast Tables
1 participant