Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LDAP values validation #509

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Fix LDAP values validation #509

merged 2 commits into from
Jan 21, 2025

Conversation

0xmeyer
Copy link
Contributor

@0xmeyer 0xmeyer commented Jan 21, 2025 •
edited by LeoColomb
Loading

Do not require .Values.remoteAuth.ldap.bindDn when .Values.remoteAuth.ldap.serverUri is specified

Fixes #508

@0xmeyer 0xmeyer changed the title fix (#508) Fix LDAP values validation (see #508) Jan 21, 2025
@0xmeyer 0xmeyer mentioned this pull request Jan 21, 2025
Closed
@LeoColomb LeoColomb changed the title Fix LDAP values validation (see #508) Fix LDAP values validation Jan 21, 2025
LeoColomb
LeoColomb requested changes Jan 21, 2025
View reviewed changes
Copy link
Member

@LeoColomb LeoColomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this pull request, @0xmeyer.
Generally looks good, but please refer to my inline comment.

charts/netbox/templates/_helpers.tpl Outdated Show resolved Hide resolved
@0xmeyer 0xmeyer force-pushed the fix-ldap-values-validation branch from 626d647 to 082550c Compare January 21, 2025 11:18
@LeoColomb LeoColomb enabled auto-merge (squash) January 21, 2025 12:31
@LeoColomb LeoColomb merged commit 0bebdc4 into netbox-community:main Jan 21, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeoColomb LeoColomb LeoColomb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to install Chart due to misconfigured LDAP values validation
2 participants
@0xmeyer @LeoColomb