Append production guidelines to NOTES #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeoColomb
force-pushed
the
leo/feat/notes
branch
3 times, most recently
from
173c81b to
a9f30ef
Compare
RangerRick
previously requested changes
Sep 9, 2024
LeoColomb
force-pushed
the
leo/feat/notes
branch
2 times, most recently
from
1bde8b3 to
19c88e2
Compare
|
Please disregard linter failure, they all relate to the README file, which will be reviewed with #331. |
RangerRick
approved these changes
Sep 18, 2024
| @@ -11,7 +11,7 @@ metadata: | |||
| type: kubernetes.io/basic-auth | |||
| data: | |||
| username: {{ .Values.superuser.name | default "admin" | b64enc | quote }} | |||
| password: {{ .Values.superuser.password | default (randAlphaNum 16) | b64enc | quote }} | |||
| password: {{ include "common.secrets.passwords.manage" (dict "secret" (include "common.secrets.name" (dict "defaultNameSuffix" "superuser" "context" $)) "key" "password" "providedValues" (list "superuser.password") "context" $) }} | |||
There was a problem hiding this comment.
hah, I ran into this in NBE at some point and just went a different route, didn't have time to look into why the common stuff wasn't working :D
LeoColomb
force-pushed
the
leo/feat/notes
branch
from
19c88e2 to
1421422
Compare
LeoColomb
force-pushed
the
leo/feat/notes
branch
from
1421422 to
7f9e86d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #187
Provides:
Bitnami's both PostgreSQL and Redis chart handled empty/generated passwords already:
For these two, there is no need to enforce empty password validation (see bitnami/charts#8534 & bitnami/charts#8518).