Issue 67

.devcontainer/devcontainer.json

@@ -78,7 +78,10 @@
 			"extensions": [
 				"DavidAnson.vscode-markdownlint",
 				"GitHub.codespaces",
+				"GitHub.copilot",
+				"GitHub.copilot-labs",
 				"GitHub.vscode-pull-request-github",
+				"Gruntfuggly.todo-tree",
 				"Tyriar.sort-lines",
 				"aaron-bond.better-comments",
 				"batisteo.vscode-django",

.devcontainer/requirements-dev.txt

@@ -12,3 +12,4 @@ pylint
 pylint-django
 wily
 yapf
+sourcery-analytics

.pre-commit-config.yaml

@@ -19,11 +19,13 @@ repos:
       - id: isort
         args:
           - "--profile=black"
+        exclude: ^.devcontainer/
   - repo: https://github.com/psf/black
     rev: 22.12.0
     hooks:
       - id: black
         language_version: python3
+        exclude: ^.devcontainer/
   - repo: https://github.com/asottile/add-trailing-comma
     rev: v2.4.0
     hooks:
@@ -34,6 +36,7 @@ repos:
     rev: 6.0.0
     hooks:
       - id: flake8
+        exclude: ^.devcontainer/
   - repo: https://github.com/asottile/pyupgrade
     rev: v3.3.1
     hooks:
@@ -44,6 +47,12 @@ repos:
     rev: v1.29.0
     hooks:
       - id: yamllint
+  - repo: https://github.com/econchick/interrogate
+    rev: 1.5.0
+    hooks:
+      - id: interrogate
+        args: [--fail-under=90, --verbose]
+        exclude: (^.devcontainer/|^netbox_acls/migrations/)
   #- repo: https://github.com/Lucas-C/pre-commit-hooks-nodejs
   #  rev: v1.1.2
   #  hooks:

Makefile

@@ -70,9 +70,13 @@ start:
 .PHONY: all ## Run all PLUGIN DEV targets
 all: setup makemigrations migrate collectstatic initializers start
 
-#.PHONY: test
-#test:
-#	${VENV_PY_PATH} /opt/netbox/netbox/manage.py runserver test ${PLUGIN_NAME}
+.PHONY: rebuild ## Run PLUGIN DEV targets to rebuild
+rebuild: setup makemigrations migrate collectstatic start
+
+.PHONY: test
+test: setup
+	${VENV_PY_PATH} ${NETBOX_MANAGE_PATH}/manage.py makemigrations ${PLUGIN_NAME} --check
+	${VENV_PY_PATH} ${NETBOX_MANAGE_PATH}/manage.py test ${PLUGIN_NAME}
 
 #relpatch:
 #	$(eval GSTATUS := $(shell git status --porcelain))

TODO

@@ -0,0 +1,7 @@
+- TODO: ACL Form Bubble/ICON Extended/Standard
+- TODO: Add an Access List to an Interface Custom Fields after comments - DONE
+- TODO: ACL rules, look at last number and increment to next 10
+- TODO: Clone for ACL Interface should include device
+- TODO: Inconsistent errors for add/edit (where model is using a generic page)
+- TODO: Check Constants across codebase for consistency.
+- TODO: Test API, Forms, & Models - https://github.com/k01ek/netbox-bgp/tree/main/netbox_bgp/tests , https://github.com/DanSheps/netbox-secretstore/tree/develop/netbox_secretstore/tests & https://github.com/FlxPeters/netbox-plugin-prometheus-sd/tree/main/netbox_prometheus_sd/tests