Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update add_device_type_components.py #93

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mostdaysarebaddays
Copy link

Update so "Devices" also filters on manufacturer, not just model

@candlerb
Copy link
Contributor

I don't think this is necessary, can you explain why you think it is?

Device type is already filtered by manufacturer: the only reason for presenting manufacturer as an input is to reduce the length of the list of device types.

Whilst device types don't have unique names (you can have two device types with the same name from different manufacturers), we're filtering devices by the device_type_id which is unambiguous.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants