[relay] Use new upstream for nhooyr.io/websocket package #3287
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
paralin
force-pushed
the
coder-websocket
branch
from
8a6c6cd to
97f12f2
Compare
paralin
changed the title
The nhooyr.io/websocket package was renamed to github.com/coder/websocket when the project was transferred to "coder" as the new maintainer. Use the new import path and update go.mod and go.sum accordingly. Signed-off-by: Christian Stewart <[email protected]>
paralin
force-pushed
the
coder-websocket
branch
from
97f12f2 to
aed3d3d
Compare
paralin
changed the title
|
|
Hey @lixmal - the test that failed here: netbird/management/server/account_test.go Line 3076 in aed3d3d It seems to have failed because it took Does that code even use websocket at all, though? As far as I can see websocket is just used in relay. Could this just be a test flake? Thanks! |
|
It's just a flake. Thanks for the PR, appreciate it! |
lixmal
approved these changes
Feb 5, 2025
|
@lixmal No problem, thank you for addressing this so quickly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nhooyr.io/websocket package was renamed to github.com/coder/websocket when the project was transferred to "coder" as the new maintainer.
Use the new import path and update go.mod and go.sum accordingly.
See #3240 cc @lixmal