-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: export REQUEST, RESPONSE tokens #688
Conversation
Hi! Any news about this PR? I really need this to be in a release. Can I be of any help? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since the README saids we must import them from @nestjs/ng-universal/tokens
:
you shouldn't add that export to lib/index.ts
. Your commit actually reverts 508bba7 but I guess something was missed in that one because currently npm run build
will leave us with the following structure:
.
├── CONTRIBUTING.md
├── dist
│ ├── angular-universal.constants.d.ts
│ ├── angular-universal.constants.js
│ ├── angular-universal.module.d.ts
│ ├── angular-universal.module.js
│ ├── angular-universal.providers.d.ts
│ ├── angular-universal.providers.js
│ ├── cache
│ ├── index.d.ts
│ ├── index.js
│ ├── interfaces
│ ├── lib
│ ├── tokens.d.ts
│ ├── tokens.js
│ └── utils
├── index.d.ts
├── index.js
├── index.ts
├── jest.config.js
├── lib
│ ├── angular-universal.constants.ts
│ ├── angular-universal.module.ts
│ ├── angular-universal.providers.ts
│ ├── cache
│ ├── index.ts
│ ├── interfaces
│ ├── tokens.ts
│ └── utils
├── LICENSE
├── package.json
├── package-lock.json
├── README.md
├── renovate.json
├── schematics
│ ├── collection.json
│ └── install
├── tsconfig.json
├── tsconfig.schematics.json
└── tslint.json
so there's no tokens.d.ts
nor tokens/index.d.ts
(at the root) to resolve to
8468c68
to
bb6adfa
Compare
@micalevisk thank you, I didn't notice that. As you said the current |
@kamilmysliwiec Since the current |
Up |
😩 |
@kamilmysliwiec would you please consider merging this PR before releasing a new version? |
As a workaround I just published a package with this fix. You can drop it into the current installation without changing imports by adding BTW: @AliYusuf95 the path must be |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #573
What is the new behavior?
Tokens can be imported directly from
@nestjs/ng-universal
Does this PR introduce a breaking change?
Other information