Clean up NESTML grammar definition #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clinssen
force-pushed
the
grammar_cleanup
branch
from
c59d7ef to
4656e3b
Compare
|
Bencher Report| Branch | 1144/merge |
| Testbed | ubuntu-latest |
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Latency | nanoseconds (ns) |
|---|---|---|
| tests/nest_continuous_benchmarking/test_nest_continuous_benchmarking.py::TestNESTContinuousBenchmarking::test_stdp_nn_synapse | 📈 view plot | 4,008,302,939.20 |
clinssen
force-pushed
the
grammar_cleanup
branch
from
4656e3b to
c1fb633
Compare
clinssen
force-pushed
the
grammar_cleanup
branch
from
c1fb633 to
00ad179
Compare
clinssen
force-pushed
the
grammar_cleanup
branch
from
00ad179 to
7b3f127
Compare
pnbabu
reviewed
Nov 29, 2024
Co-authored-by: Pooja Babu <[email protected]>
pnbabu
approved these changes
Dec 2, 2024
|
Great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the unit tests (
nestml_printer_test.py) was silently failing on master, giving parse errors which were not resulting in exceptions/test failures.This PR fixes the issue and cleans up (internally refactors) the NESTML grammar definition.
The term "block" only refers to top-level elements in a model (update, state, parameters, onReceive, etc.) The inner "ASTBlock" was renamed to ASTStmtsBody as it includes an INDENT in the grammar rule.