Integrate the entire dynamics for higher-order ODEs #1139
Conversation
|
Bencher Report| Branch | 1139/merge |
| Testbed | ubuntu-latest |
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Latency | nanoseconds (ns) |
|---|---|---|
| tests/nest_continuous_benchmarking/test_nest_continuous_benchmarking.py::TestNESTContinuousBenchmarking::test_stdp_nn_synapse | 📈 view plot | 3,954,045,038.80 |
| fig.savefig("/tmp/test_integrate_odes_higher_order.png", dpi=300) | ||
|
|
||
| # verify | ||
| np.testing.assert_allclose(x[-1], 0.10737970490959549) |
There was a problem hiding this comment.
How do we know these values are correct (are they from just running the NESTML model once, or from an independent implementation of the ODEs)?
There was a problem hiding this comment.
These values are from repeated simulations of the NESTML-generated code, equivalent to providing integrate_odes(x',x) in the NESTML model. I have changed the test now to include calls to both integrate_odes and compare their output.
There was a problem hiding this comment.
With the latest changes, integrate_odes(x, x') is not supported and hence I changed the test again to compare it against numerical values. Do you have any other ideas to check this?
|
Thanks for the PR! Could you add/update the documentation for the |
| integrate_odes(x) | ||
| # integrate_odes(x', x) # equivalent to integrate_odes(x) | ||
|
|
||
| Here, ``integrate_odes(x)`` integrates the entire dynamics of ``x(t)`` and is equivalent to ``integrate_odes(x', x)``. |
There was a problem hiding this comment.
Should it be allowed to write variables with derivatives inside integrate_odes() at all? As in, x is allowed, but x' is not. Otherwise, what is the semantics of saving integrate_odes(x')?
There was a problem hiding this comment.
I have now updated one of the existing cocos to check this condition.
No description provided.