Skip to content

Commit

Permalink
Bump minimum Python version requirement to 3.9 and update CI (#1138)
Browse files Browse the repository at this point in the history
  • Loading branch information
clinssen authored Nov 6, 2024
1 parent ac9b6e5 commit 01af597
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 16 deletions.
28 changes: 14 additions & 14 deletions .github/workflows/nestml-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@ jobs:
uses: actions/checkout@v4

# Setup Python version
- name: Setup Python 3.8
- name: Setup Python 3.9
uses: actions/setup-python@v5
with:
python-version: 3.8
python-version: 3.9

# Install dependencies
- name: Install apt dependencies
Expand Down Expand Up @@ -60,10 +60,10 @@ jobs:
uses: actions/checkout@v4

# Setup Python version
- name: Setup Python 3.8
- name: Setup Python 3.9
uses: actions/setup-python@v5
with:
python-version: 3.8
python-version: 3.9

# Install dependencies
- name: Install apt dependencies
Expand Down Expand Up @@ -99,7 +99,7 @@ jobs:
# Install NESTML
- name: Install NESTML
run: |
export PYTHONPATH=${{ env.PYTHONPATH }}:${{ env.NEST_INSTALL }}/lib/python3.8/site-packages
export PYTHONPATH=${{ env.PYTHONPATH }}:${{ env.NEST_INSTALL }}/lib/python3.9/site-packages
#echo PYTHONPATH=`pwd` >> $GITHUB_ENV
echo "PYTHONPATH=$PYTHONPATH" >> $GITHUB_ENV
python setup.py install
Expand Down Expand Up @@ -131,10 +131,10 @@ jobs:
uses: actions/checkout@v4

# Setup Python version
- name: Setup Python 3.8
- name: Setup Python 3.9
uses: actions/setup-python@v5
with:
python-version: 3.8
python-version: 3.9

# Install dependencies
- name: Install apt dependencies
Expand Down Expand Up @@ -169,7 +169,7 @@ jobs:
# Install NESTML
- name: Install NESTML
run: |
export PYTHONPATH=${{ env.PYTHONPATH }}:${{ env.NEST_INSTALL }}/lib/python3.8/site-packages
export PYTHONPATH=${{ env.PYTHONPATH }}:${{ env.NEST_INSTALL }}/lib/python3.9/site-packages
#echo PYTHONPATH=`pwd` >> $GITHUB_ENV
echo "PYTHONPATH=$PYTHONPATH" >> $GITHUB_ENV
python setup.py install
Expand All @@ -195,10 +195,10 @@ jobs:
uses: actions/checkout@v4

# Setup Python version
- name: Setup Python 3.8
- name: Setup Python 3.9
uses: actions/setup-python@v5
with:
python-version: 3.8
python-version: 3.9

# Install dependencies
- name: Install apt dependencies
Expand Down Expand Up @@ -252,7 +252,7 @@ jobs:
# Install NESTML (repeated)
- name: Install NESTML
run: |
export PYTHONPATH=${{ env.PYTHONPATH }}:${{ env.NEST_INSTALL }}/lib/python3.8/site-packages
export PYTHONPATH=${{ env.PYTHONPATH }}:${{ env.NEST_INSTALL }}/lib/python3.9/site-packages
#echo PYTHONPATH=`pwd` >> $GITHUB_ENV
echo "PYTHONPATH=$PYTHONPATH" >> $GITHUB_ENV
python setup.py install
Expand Down Expand Up @@ -331,10 +331,10 @@ jobs:
uses: actions/checkout@v4

# Setup Python version
- name: Setup Python 3.8
- name: Setup Python 3.9
uses: actions/setup-python@v5
with:
python-version: 3.8
python-version: 3.9

# Install dependencies
- name: Install apt dependencies
Expand Down Expand Up @@ -370,7 +370,7 @@ jobs:
# Install NESTML (repeated)
- name: Install NESTML
run: |
export PYTHONPATH=${{ env.PYTHONPATH }}:${{ env.NEST_INSTALL }}/lib/python3.8/site-packages
export PYTHONPATH=${{ env.PYTHONPATH }}:${{ env.NEST_INSTALL }}/lib/python3.9/site-packages
#echo PYTHONPATH=`pwd` >> $GITHUB_ENV
echo "PYTHONPATH=$PYTHONPATH" >> $GITHUB_ENV
python setup.py install
Expand Down
2 changes: 1 addition & 1 deletion doc/installation.rst
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Installing NESTML
=================

Please note that only Python 3.8 (and later versions) are supported. The instructions below assume that ``python`` is aliased to or refers to ``python3``, and ``pip`` to ``pip3``.
Please note that only Python 3.9 (and later versions) are supported. The instructions below assume that ``python`` is aliased to or refers to ``python3``, and ``pip`` to ``pip3``.

Installing the latest release from PyPI
---------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
import sys
from setuptools import setup, find_packages

assert sys.version_info.major >= 3 and sys.version_info.minor >= 8, "Python 3.8 or higher is required to run NESTML"
assert sys.version_info.major >= 3 and sys.version_info.minor >= 9, "Python 3.9 or higher is required to run NESTML"

with open("requirements.txt") as f:
requirements = f.read().splitlines()
Expand Down

0 comments on commit 01af597

Please sign in to comment.