Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test github workflow update against prow #27

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

efiacor
Copy link
Collaborator

@efiacor efiacor commented Feb 29, 2024

Verify if prow tide merge flow is blocked by an edit to an existing github workflow.

@liamfallon
Copy link
Member

/lgtm
/approve

Copy link
Member

@electrocucaracha electrocucaracha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for test purposes right?
/lgtm

@efiacor
Copy link
Collaborator Author

efiacor commented Feb 29, 2024

This is for test purposes right? /lgtm

Essentially yes. I want to see if prow:tide will get stuck as it does when adding a "new" workflow.

@henderiw
Copy link

/approve
/lgtm

Copy link
Member

@liamfallon liamfallon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@liamfallon
Copy link
Member

/lgtm
/approve

Copy link
Contributor

nephio-prow bot commented Mar 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: efiacor, electrocucaracha, henderiw, liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tliron tliron merged commit bba3372 into nephio-project:main Mar 4, 2024
4 checks passed
@efiacor efiacor deleted the test_gh_action_edit_prow branch March 12, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants