Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for #736 Implement missing Modify event on the porch Repo Custom Resource #167

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mansoor17syed
Copy link

No description provided.

@nephio-prow nephio-prow bot requested a review from henderiw January 9, 2025 09:14
Copy link
Contributor

nephio-prow bot commented Jan 9, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mansoor17syed
Once this PR has been reviewed and has the lgtm label, please assign henderiw for approval by writing /assign @henderiw in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mansoor17syed
Copy link
Author

Hi Team,

Based on the comments and changes here nephio-project/nephio#736 , I understand that we are not returning anything.
Could you clarify if the expectation is to simply fix this or to add changes that handle the update action for a CR?

Either way, I have raised an MR to address this by just returning it. I'm not entirely sure how effective this approach is, so I would appreciate it if you could review and share your feedback.

#167

nephio-project/nephio#736 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant