Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a Rdbms prototype repository for Porch #124

Open
wants to merge 38 commits into
base: main
Choose a base branch
from
Open

Implement a Rdbms prototype repository for Porch #124

wants to merge 38 commits into from

Conversation

liamfallon
Copy link
Member

No description provided.

@nephio-prow Nephio PROW
Copy link
Contributor

nephio-prow bot commented Oct 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Oct 14, 2024
@liamfallon
Copy link
Member Author

/retest

@liamfallon
Copy link
Member Author

/retest

@nephio-prow nephio-prow bot added the approved label Oct 16, 2024
@liamfallon liamfallon changed the title Rdbms prototype Implement a Rdbms prototype repository for Porch Oct 23, 2024
@nagygergo
Copy link
Contributor

Could you add a makefile entry on setting up porch with a db repository

@liamfallon liamfallon force-pushed the rdbms-prototype branch 3 times, most recently from e152270 to 89a27f9 Compare November 4, 2024 16:39
@liamfallon
Copy link
Member Author

/retest

@liamfallon liamfallon force-pushed the rdbms-prototype branch 3 times, most recently from 4cfd557 to 844d9e8 Compare December 3, 2024 14:36
@liamfallon liamfallon force-pushed the rdbms-prototype branch 2 times, most recently from 82f08b3 to 24cdf07 Compare December 16, 2024 11:07
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 7, 2025
View reviewed changes
pkg/cache/dbcache/dbpackagerevisionsql.go Outdated
Comment on lines 85 to 94
rows.Scan(
&pkgRev.pkgRevKey.Namespace,
&pkgRev.pkgRevKey.Repository,
&pkgRev.pkgRevKey.Package,
&pkgRev.pkgRevKey.Revision,
&pkgRev.pkgRevKey.WorkspaceName,
&pkgRev.updated,
&pkgRev.updatedBy,
&pkgRev.lifecycle,
&rawResources)

Check warning

Code scanning / gosec

Errors unhandled. Warning

Errors unhandled.
pkg/cache/dbcache/dbpackagesql.go Fixed Show fixed Hide fixed
pkg/cache/dbcache/dbrepository.go

func (r *dbRepository) setMetaFromJson(jsonMeta string) {
r.meta = &metav1.ObjectMeta{}
json.Unmarshal([]byte(jsonMeta), r.meta)

Check warning

Code scanning / gosec

Errors unhandled. Warning

Errors unhandled.
pkg/cache/dbcache/dbrepository.go

func (r *dbRepository) setSpecFromJson(jsonSpec string) {
r.spec = &configapi.RepositorySpec{}
json.Unmarshal([]byte(jsonSpec), r.spec)

Check warning

Code scanning / gosec

Errors unhandled. Warning

Errors unhandled.
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 9, 2025
View reviewed changes
pkg/cache/dbcache/dbpackage.go Fixed Show fixed Hide fixed
pkg/cache/dbcache/dbpackage.go Fixed Show fixed Hide fixed
pkg/cache/dbcache/dbpackagerevision.go Fixed Show fixed Hide fixed
pkg/cache/dbcache/dbpackagerevision.go Fixed Show fixed Hide fixed
pkg/cache/dbcache/dbpackagerevisionresourcessql.go
Comment on lines +70 to +72
rows.Scan(
&resKey,
&resVal)

Check warning

Code scanning / gosec

Errors unhandled. Warning

Errors unhandled.
pkg/cache/dbcache/dbpackagesql.go
Comment on lines +72 to +79
rows.Scan(
&pkg.pkgKey.Namespace,
&pkg.pkgKey.Repository,
&pkg.pkgKey.Package,
&metaAsJson,
&specAsJson,
&pkg.updated,
&pkg.updatedBy)

Check warning

Code scanning / gosec

Errors unhandled. Warning

Errors unhandled.
@liamfallon
Remove namespace from package names
e2c74a9
@liamfallon
Return pointer rather than instance on read of PackageRevision from db
b640fa3
@liamfallon
Fix up comments after rebase
59d5448
@liamfallon
Fix up comments after rebase
321b961
@liamfallon
Update db repo due to rebases
61342eb
@liamfallon
Rebased against main
260064e
@liamfallon
Added config for db tutorial
7c2509e
@liamfallon
Added package resource perisistence
c94cd43
@liamfallon
porchctl pull/push supported
8e5d77f
@liamfallon
Fix push deleting resources on package on no change push
890266f
@liamfallon
Propose delete now working
563a035
@liamfallon
Add namespace to db creation Yaml file
39cd0fa
@liamfallon
Remove namespace from package names
c487ecb
@liamfallon
Return pointer rather than instance on read of PackageRevision from db
95fa846
@liamfallon
Fix up comments after rebase
95f576b
@liamfallon
Fix up comments after rebase
2c06031
@liamfallon
Update db repo due to rebases
1dca0ac
@liamfallon
Use a RDBMS as a cache in Porch
2f476f8
@liamfallon
Rebase against main
89ae85b
@liamfallon
rebase
1c65878
@liamfallon
Latest update
7933a91
@liamfallon
Tutorial update
1196f8c
@liamfallon
Correct trace statement
bfd7740
@liamfallon
Added handling for resources
cf0c24b
@liamfallon
Updated to handle subpackages
f10b590
@liamfallon
Clean up lint flags
e72b5c9
@liamfallon
Refactored code to put repository implementations and cache implement…
40de272 
…ations behind interfaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efiacor efiacor Awaiting requested review from efiacor

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

Assignees
No one assigned
Labels
approved do-not-merge/work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liamfallon @nagygergo